1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/sbbsecho.c

    From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Oct 31 19:44:42 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/3b527199322f25832617f964
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix potential buffer overflow in fmsgattr_str()

    Pass it 0xffff and it overflows its local (static) string buffer.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Fri Oct 31 20:24:54 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/41e2191514f2a45fe862b6b4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Replace import_netmail() magic constansts with (expanded) IMPORT_* enum values

    The only really important values (other than for debug-logging reasons) are
    0 (success) and IMPORT_CLOSED (was -2).

    One functional change included here: when fmsgtosmsg returned non-zero values, import_netmail() would log the value and still return 0 (success). This will result in more debug-level log msgs when fmsgtosmsg() returns an error value, but that's all.

    The logged import_netmail() error numbers *are* changed by this commit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Fri Oct 31 23:19:30 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/d5b59539e7e688f57ce3c43e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Implement Deuce's suggested fix for importing netmail messages (.msg files)

    ... for robots.

    I thought he said he was importing packets, but in any case, we don't want to be deleting a .msg file destined for a configured robot.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 1 13:48:11 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e7b93ae3f3f8dfb24d450f1c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Clean up import_netmail()

    - No longer use special return value (IMPORT_CLOSED) to indicate the .msg
    file was closed. Now we just set the FILE* to NULL if it was closed and
    return IMPORT_SUCCESS.
    - No longer deletes the .msg file here; expect the caller (main()) to do that. - Update the message header here (e.g. adding "RECEIVED" attribute flag),
    when appropriate. Sometimes this was added here, sometimes in the main(),
    and in some cases it should not have been added (e.g. for ignored and
    filtered netmail messages) but it was anyway.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 1 14:11:05 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/5b21df6e401a7b3071c44f8b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit

    Weird that it compiled without warning. I didn't try linking it, so that's why it wasn't caught.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Nov 9 14:47:50 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f8a33572e1e6fe5ac9887856
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Remove direct printf() calls from import_netmail()

    ... direct all output through lprintf() instead.

    This insures that the helpful output may always be logged to the sbbsecho.log file and the sysop need not view the stdout to find out why a netmail message was ignored or discarded or otherwise problematic.

    It appeared there may have been redundant output to stdout before anyway and trying to keep both the stdout and the log output both helpful and beautified was getting tedius.

    Most sysops don't look at the console/stdout of sbbsecho when it runs and we normally expect a sysop to be able to use the sbbsecho.log file to debug any issues (possibly after increasing their log level to DEBUG).

    Include the netmail message attributes value (both in hex and verbose form)
    in the information logged about an incoming netmail message.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net